Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "close" icon when navbar-toggler is clicked #252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

antriksh-9
Copy link
Contributor

Fixes #251

Describe the changes you have made in this PR -

Added a "close" icon, replacing the the default icon navbar-toggler when it is clicked.

Screenshots of the changes (If any) -

solution.mp4

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for circuitverse ready!

Name Link
🔨 Latest commit 761b2a4
🔍 Latest deploy log https://app.netlify.com/sites/circuitverse/deploys/6599641da6928e00088f6296
😎 Deploy Preview https://deploy-preview-252--circuitverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antriksh-9
Copy link
Contributor Author

Hey @tanmoysrt @Prerna-0202 please review.

@tanmoysrt
Copy link
Member

Hey @tanmoysrt @Prerna-0202 please review.

cc @Arnabdaz

@Arnabdaz Arnabdaz added the hold label Jan 6, 2024
@Arnabdaz
Copy link
Member

Arnabdaz commented Jan 6, 2024

keeping your pr on hold as there is already a pr for navbar upgrade #177 & as it is related to mobile version of simulator it needs to implemented after proper planning
you can always use this pr as proof of work.

@DhairyaMajmudar
Copy link
Contributor

Hi @antriksh-9 this issue is already completed by the pr CircuitVerse/CircuitVerse#4502

@antriksh-9
Copy link
Contributor Author

Hey @DhairyaMajmudar this PR solves the issue for vue-simulator and not for the main website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding "close" icon when navbar-toggler is clicked
4 participants